Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Changed encoded float::Inf as null in json #1427

Merged

Conversation

SimonSchneider
Copy link
Contributor

fixes: #1423

I took the liberty of creating a PR for this fix.

@SimonSchneider SimonSchneider force-pushed the fix/json-float-inf-as-null branch from 0c297fe to e51ecef Compare March 7, 2023 07:17
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (fa2c51c) 83.76% compared to head (cbbf97f) 83.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1427   +/-   ##
=======================================
  Coverage   83.76%   83.76%           
=======================================
  Files         374      374           
  Lines       40955    40955           
=======================================
  Hits        34307    34307           
  Misses       6648     6648           
Impacted Files Coverage Δ
src/io/json/write/serialize.rs 92.17% <100.00%> (ø)
src/io/ipc/read/array/boolean.rs 92.45% <0.00%> (-5.67%) ⬇️
src/io/ipc/read/file.rs 96.87% <0.00%> (+0.44%) ⬆️
src/bitmap/immutable.rs 87.20% <0.00%> (+0.58%) ⬆️
src/bitmap/utils/slice_iterator.rs 98.78% <0.00%> (+1.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SimonSchneider SimonSchneider force-pushed the fix/json-float-inf-as-null branch from e51ecef to c0b3b86 Compare March 7, 2023 07:21
@jorgecarleitao jorgecarleitao added the bug Something isn't working label Mar 7, 2023
@jorgecarleitao jorgecarleitao changed the title fix: encode float::Inf as null in json Changed encoded float::Inf as null in json Mar 7, 2023
@jorgecarleitao
Copy link
Owner

Thank you! 🙇

@jorgecarleitao jorgecarleitao merged commit ac1dfaf into jorgecarleitao:main Mar 7, 2023
@SimonSchneider SimonSchneider deleted the fix/json-float-inf-as-null branch March 7, 2023 20:18
ritchie46 pushed a commit to ritchie46/arrow2 that referenced this pull request Mar 29, 2023
ritchie46 pushed a commit to ritchie46/arrow2 that referenced this pull request Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serialising Inf float produces invalid JSON
2 participants